Improved fix for IndexOutOfBoundsException#2403
Merged
yaRnMcDonuts merged 1 commit intojMonkeyEngine:masterfrom Apr 21, 2025
Merged
Improved fix for IndexOutOfBoundsException#2403yaRnMcDonuts merged 1 commit intojMonkeyEngine:masterfrom
yaRnMcDonuts merged 1 commit intojMonkeyEngine:masterfrom
Conversation
Member
|
Looks good to me. I'll merge this within the next day or two. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, this is @pspeed42 's patch applied on top of master. I did not revert #2297, I kept the good parts from the original patch. But I did not include the fix for the symptom just to be sure that everything is always ok and we don't accidentally always just fallback to costly bandaid.