Add defensive copy to EmitterShape's Vector3f#2406
Closed
capdevon wants to merge 17 commits intojMonkeyEngine:masterfrom
Closed
Add defensive copy to EmitterShape's Vector3f#2406capdevon wants to merge 17 commits intojMonkeyEngine:masterfrom
capdevon wants to merge 17 commits intojMonkeyEngine:masterfrom
Conversation
capdevon
changed the title
Contributor
Author
|
Closing PR: Based on Feedback: This PR has the potential to break existing code that relies on a shared shape position across multiple emitter shapes. Specifically, any code designed to have changes propagate through external modifications would be affected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A defensive copy is created to ensure that any external modifications to the original Vector3f objects will not affect the EmitterShape's internal state.