DefaultParticleInfluencer: incorrect cloning of variables#2407
Merged
yaRnMcDonuts merged 8 commits intojMonkeyEngine:masterfrom May 16, 2025
Merged
DefaultParticleInfluencer: incorrect cloning of variables#2407yaRnMcDonuts merged 8 commits intojMonkeyEngine:masterfrom
yaRnMcDonuts merged 8 commits intojMonkeyEngine:masterfrom
Conversation
capdevon
changed the title
JmeCloneable already extends the Cloneable interface so you can remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the overridden
clone()method from theNewtonianParticleInfluencerclass. This method duplicates functionality present in the superclass. Furthermore, the manual cloning of primitive fields is redundant as Java handles this automatically.In addition, this PR solves the problems of cloning class variables that extend the superclass
DefaultParticleInfluencer. The fix is backward compatible and should not cause problems with older applications.