Conversation
Resync fork
Update fork
… in the atlases instead of setting a predefined byte buffer on disposal that made all atlases in the backend use the same buffer and generated rendering issues.
Fork update
…d more images to the screens so it really uses more atlases
Update fork PR
Update fork
Update fork
|
You should probably write at least one test for this. |
If |
|
Thanks for the comments @codex128 , OK, I would write some, but... Which kind of tests do you want me to do? Also, how could I make them run either when compiling locally or in github actions if this code is intended to run only on iOS? @stephengold , checked and the artifact is saved properly to mavenLocal. I had to make a small change so the jar is properly created when running "gradlew install". Thanks for the tip |
codex128
left a comment
There was a problem hiding this comment.
Huge thanks for this PR, and I apologize that it didn't get better attention sooner. Just a few things I noticed that need changing.
codex128
left a comment
There was a problem hiding this comment.
Looks good, thanks @joliver82
@yaRnMcDonuts this is ready whenever you are
Pending to add jme3-ios-native library to be uploaded to maven. Any help is appreciated