jme3-examples: TestReverb code cleanup#2419
Merged
yaRnMcDonuts merged 9 commits intojMonkeyEngine:masterfrom May 10, 2025
Merged
jme3-examples: TestReverb code cleanup#2419yaRnMcDonuts merged 9 commits intojMonkeyEngine:masterfrom
yaRnMcDonuts merged 9 commits intojMonkeyEngine:masterfrom
Conversation
Refactored the TestReverb example code for improved clarity. This commit restructures the demo to explicitly highlight its individual components, making it easier to understand the flow and functionality.
capdevon
changed the title
Added more test Environments and some options to enable/disable the Reverb Filter
Contributor
Author
|
@yaRnMcDonuts Wait a bit before merge this PR, I am using it to test the combined effects of the Environment and Reverb Filters. I will let you know when it is ready ;) Edit: |
Contributor
Author
|
@yaRnMcDonuts, the PR is now complete and ready to be merged or reviewed ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the
TestReverbexample code for improved clarity. This commit restructures the demo to explicitly highlight its individual components, making it easier to understand the flow and functionality.