jme3-examples: add TestDeviceDisconnect class#2433
Merged
yaRnMcDonuts merged 1 commit intojMonkeyEngine:masterfrom May 15, 2025
Merged
jme3-examples: add TestDeviceDisconnect class#2433yaRnMcDonuts merged 1 commit intojMonkeyEngine:masterfrom
yaRnMcDonuts merged 1 commit intojMonkeyEngine:masterfrom
Conversation
yaRnMcDonuts
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test demonstrates that destroying and recreating the
OpenAL Contextupon device disconnection is suboptimal. As evidenced, loopingAudioNodeinstances stop playing after disconnection and require manual restarting. This test solely highlights this issue, which warrants a more robust solution within theALAudioRendererclass in a future Git pull request.We could look at
libGDX's approach to these problemshttps://github.com/libgdx/libgdx/blob/master/backends/gdx-backend-lwjgl3/src/com/badlogic/gdx/backends/lwjgl3/audio/OpenALLwjgl3Audio.java#L128
Edit:
Maybe it's best to close this PR and open an Issue with the code so we can reproduce, test, and potentially fix it.