Skip to content

Update DirectionalLightShadowRenderer.java #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmtcasel wants to merge 1 commit into from
Closed

Update DirectionalLightShadowRenderer.java #2569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion jme3-core/src/main/java/com/jme3/shadow/DirectionalLightShadowRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,14 @@ protected GeometryList getOccludersToRender(int shadowMapIndex, GeometryList sha
ShadowUtil.updateFrustumPoints(viewPort.getCamera(), splitsArray[shadowMapIndex], splitsArray[shadowMapIndex + 1], 1.0f, points);

//Updating shadow cam with current split frusta
if (lightReceivers.size()==0) {
if (lightReceivers.size()==0)

// Fix: prevent null viewport or null scene list
if (viewPort == null || viewPort.getScenes() == null) {
Copy link
Contributor

@codex128 codex128 Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not possible for viewPort to be null at any point after processor initialization, and viewPort.getScenes() is never null.

Also, this code doesn't work. You inserted the if statement between another if's condition and body.

return shadowMapOccluders;
}

{
for (Spatial scene : viewPort.getScenes()) {
ShadowUtil.getGeometriesInCamFrustum(scene, viewPort.getCamera(), RenderQueue.ShadowMode.Receive, lightReceivers);
}
Expand Down
Loading