Merged
Conversation
Fixes an exception caused by duplicate declaration of the same variables when using fog. The fog uniforms are already declared in the imported fog glsllib, so the declaration in the .frag shader causes an exception trying to re-declare them a second time.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the fog implementation in the SPLighting.frag shader by replacing manual uniform declarations and conditional fog logic with a centralized library import from MaterialFog.glsllib. A review comment identifies a redundant vec4 constructor call when calculating the final fog color, suggesting a simplification to improve code readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an exception caused by duplicate declaration of the same variables when using fog.
The fog uniforms are already declared in the imported fog glsllib, so the declaration in the .frag shader causes an exception trying to re-declare them a second time.