Issue #651 save asset node in TerrainEditorController#653
Merged
neph1 merged 3 commits intojMonkeyEngine:masterfrom Jun 18, 2025
Merged
Issue #651 save asset node in TerrainEditorController#653neph1 merged 3 commits intojMonkeyEngine:masterfrom
neph1 merged 3 commits intojMonkeyEngine:masterfrom
Conversation
neph1
commented
Jun 16, 2025
f98e316 to
b2f463a
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the TerrainEditorController to properly save the terrain asset after changes, modernizes thread enqueuing to use lambdas, and cleans up unused imports.
- Always enqueue
currentFileObject.saveAsset()after saving alpha layers. - Replace anonymous
Callableclasses with lambda expressions for conciseness. - Remove unused imports and update copyright year.
Comments suppressed due to low confidence (2)
jme3-terrain-editor/src/com/jme3/gde/terraineditor/TerrainEditorController.java:146
- The original conditional logic around
setModifiedwas removed, so this now always toggles the flag—even if it wasn't intended; restore the previous checks to avoid inadvertently clearing or setting the modified state.
currentFileObject.setModified(state);
jme3-terrain-editor/src/com/jme3/gde/terraineditor/TerrainEditorController.java:108
- [nitpick] There are many repeated
enqueuecalls with similar lambda patterns; consider extracting a helper method (e.g.,runOnSceneThread(Runnable)) to reduce duplication and improve readability.
SceneApplication.getApplication().enqueue(() -> { doSaveAlphaImages(); return null; });
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #651