Merged
Conversation
Owner
Author
|
Re-run checks after GitHub rollback is complete, see actions/runner-images#13341 (comment) |
There was a problem hiding this comment.
Pull request overview
This PR updates rdev to version 1.15.3, which adds functionality to disable pkgdown's new build_llm_docs() feature by default when setting up pkgdown with rdev conventions.
Key Changes
- Modified
use_rdev_pkgdown()to setllm-docs: falsein the pkgdown configuration - Added test coverage for the new llm-docs configuration
- Updated documentation to reflect the new behavior
- Updated package dependencies in renv.lock (R 4.5.2, pkgdown 2.2.0, and others)
Reviewed changes
Copilot reviewed 68 out of 73 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| R/setup.R | Added pkg$'llm-docs' <- FALSE to disable LLM docs generation |
| tests/testthat/test-setup.R | Added test assertion to verify llm-docs is disabled |
| tests/testthat/test-upkeep.R | Updated expected upkeep checklist length for 2025 |
| man/use_rdev_pkgdown.Rd | Updated documentation to describe llm-docs disabling |
| renv.lock | Updated R version and package dependencies |
| docs/* | Generated documentation files from pkgdown build |
The changes are appropriate and well-tested. The implementation correctly disables the llm-docs feature in pkgdown configuration, and the test coverage validates this behavior. The documentation accurately describes the new functionality.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use_rdev_pkgdown()to disable the newpkgdown::build_llm_docs()by default (updateuse_rdev_pkgdown())