Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 30, 2025

The formatting-preservation-test.rkt file contained tests verifying that refactoring rules preserve formatting of unmodified code. These tests were separated from the other tests for the same rules, making them harder to maintain.

Changes

  • Moved nested or formatting test → boolean-shortcuts-test.rkt
  • Moved let-to-define and define-let-to-double-define formatting tests → let-replacement-test.rkt
  • Moved cond-let-to-cond-define formatting test → cond-let-replacement-test.rkt
  • Deleted formatting-preservation-test.rkt

Each test now lives alongside other tests for its corresponding rule, making the test suite structure more consistent with the rest of the codebase.

Original prompt

This section details on the original issue you should resolve

<issue_title>Formatting preservation test cases should be split up</issue_title>
<issue_description>The formatting-preservation-test.rkt file contains a handful of test cases that check that various Resyntax rules don't reformat more code than expected. But those sorts of tests are also spread across the rest of Resyntax's test suite, alongside other tests for the rule in question. Since this behavior is (mostly) up to the rule to handle correctly, it would make more sense for the tests in formatting-preservation-test.rkt to be moved to the existing rule-specific test files.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Refactor formatting preservation test cases Move formatting preservation tests to rule-specific test files Oct 30, 2025
Copilot AI requested a review from jackfirth October 30, 2025 03:18
@jackfirth jackfirth marked this pull request as ready for review October 30, 2025 04:29
@jackfirth jackfirth enabled auto-merge (squash) October 30, 2025 04:31
@jackfirth jackfirth merged commit 5176599 into master Oct 30, 2025
4 checks passed
@jackfirth jackfirth deleted the copilot/split-formatting-preservation-tests branch October 30, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Formatting preservation test cases should be split up

2 participants