Fix code_quality workflow: update lockfile and improve validation #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated pytest-benchmark from v5.1.0 to v5.2.3 to match pyproject.toml - Removed unnecessary tomli dependency entries with impossible markers - Lockfile is now in sync with pyproject.toml requirements Co-authored-by: jacksonpradolima <[email protected]>
Copilot
AI
changed the title
[WIP] Fix code quality workflow to update lockfile
Update uv.lock to fix code_quality workflow
Jan 1, 2026
Owner
|
@copilot why not have a step before --check to update lock? it's safer |
- Add uv lock step before checking lockfile freshness - Check git diff to detect if lockfile needs updating - Provide clear error message and show diff when lockfile is out of sync - This is safer and more informative than just using uv lock --check Co-authored-by: jacksonpradolima <[email protected]>
Contributor
Author
Good suggestion! I've updated the workflow in commit 33dff77 to add a
This approach is safer and more informative than just using |
- Check lockfile first with uv lock --check (fast path) - Only regenerate lockfile if check fails (to show diff) - Provides helpful error message showing exact changes needed - More efficient while still being informative Co-authored-by: jacksonpradolima <[email protected]>
- Add 'set -e' to ensure script fails on any command error - Ensures uv lock failures are properly caught and reported Co-authored-by: jacksonpradolima <[email protected]>
|
Copilot
AI
changed the title
Update uv.lock to fix code_quality workflow
Fix code_quality workflow: update lockfile and improve validation
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
code_quality.ymlworkflow was failing onuv lock --checkbecause the lockfile was out of sync withpyproject.toml.Changes
Lockfile Update
uv.lockto match current dependency specificationspytest-benchmark: 5.1.0 → 5.2.3 (matchespyproject.tomlpin)tomlientries with impossible version markersWorkflow Improvement
code_quality.ymlto be more informative and efficient:uv lock --checkfirst (fast path when lockfile is up-to-date)set -efor proper error handlingThe lockfile check now passes and
uv sync --frozenworks as expected. The improved workflow provides better developer experience by clearly showing what needs to be updated when the lockfile is out of sync.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.