Make children prop optional #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When will this be merged? It's broken all my Flatpickr components and forced me to create my own typing until this is resolved. |
Author
Good question. I don't have write permissions, otherwise I'd have done it myself lol. I ended up switching to svelte-flatpickr-plus since it's a bit more active. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Flatpickr component has an optional fallback for its default slot here.
The current typing, as far as Svelte 5 is concerned, expects something to always be provided to go in the slot.
Making the
childrenprop optional means that Svelte 5 will now allow the optional fallback to be used instead of always expecting something to be provided for the slot.