KotlinComposeFilter should filter bytecode generated for pausable composition #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godin
changed the title
Godin
force-pushed
the
KotlinComposeFilter
branch
from
3a7c0c6 to
d803515
Compare
marchof
reviewed
Aug 28, 2025
|
|
||
| m.visitVarInsn(ALOAD, 0); | ||
| range1.fromInclusive = m.instructions.getLast(); | ||
| m.visitLdcInsn(Integer.valueOf(-933543558)); |
There was a problem hiding this comment.
Just out of curiosity: What is this specific number about?
There was a problem hiding this comment.
@marchof "FunctionSourceKey" which is some hash code of function - see
- https://github.com/JetBrains/kotlin/blob/c448af19ded1b1a4e96e9af6412cd9acb100ce1a/plugins/compose/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposableFunctionBodyTransformer.kt#L1200-L1204
- https://github.com/JetBrains/kotlin/blob/c448af19ded1b1a4e96e9af6412cd9acb100ce1a/plugins/compose/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposableFunctionBodyTransformer.kt#L1953-L1956
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jacoco/example-jacoco-kotlin-compose#76
without this change produces
after this change
See