Converting Bowser to Angular Constant & Code Clean-Up #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Bowser Service is great! My team and I use it everywhere! However, we make configurations in our modules based on the browser type. I would be beneficial to us and other users to convert this into a constant. Not only will it be available in BOTH providers and services, but it is better suited as a constant since it does not change while you have an instance of an application running. In addition, I also did a little clean-up with semi-colons and ===
|
Nice, thanks for the feedback. But the code is basically copy pasted from ded's bowser project. Making it a constant is a good idea. I will also sync the code with ded's. |
jacqueslareau
pushed a commit
that referenced
this pull request
Dec 14, 2015
updating to the new version of bowser which includes all the edge det…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Bowser Service is great! My team and I use it everywhere! However, we make configurations in our modules based on the browser type. I would be beneficial to us and other users to convert this into a constant. Not only will it be available in BOTH providers and services, but it is better suited as a constant since it does not change while you have an instance of an application running.
In addition, I also did a little clean-up with semi-colons and ===