Skip to content

Update lxml to Enhance Compatibility and Stability #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v4
Choose a base branch
from
Open

Update lxml to Enhance Compatibility and Stability #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
build/
dist/
*egg-info/

get-poetry.py
# Don't commit files from integration test output
tests/integration/output/**.csv
tests/integration/output/**.json
Expand All @@ -13,3 +13,5 @@ tests/integration/output/**.json
.coverage

dependencies/*

.vscode/
128 changes: 97 additions & 31 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ python = "^3.7"
certifi = "==2018.10.15"
chardet = "==3.0.4"
idna = "==2.7"
lxml = "==4.5.1"
lxml = "^4.6.3"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #250 increased the version of lxml to ^4.9.1. So this change would be a lxml version downgrade - feel free to bump the lxml version to a more recent version

pytz = "==2018.6"
requests = "==2.20.0"
urllib3 = "==1.24.3"
Expand Down