Implement max trace size parameter #7810
Open
+286
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parship Chowdhury <[email protected]>
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (86.53%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7810 +/- ##
==========================================
- Coverage 95.49% 95.47% -0.03%
==========================================
Files 312 312
Lines 16511 16561 +50
==========================================
+ Hits 15767 15811 +44
- Misses 580 585 +5
- Partials 164 165 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
requested changes
Dec 31, 2025
cmd/jaeger/internal/extension/jaegerquery/internal/querysvc/v2/querysvc/service_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Parship Chowdhury <[email protected]>
Parship12
force-pushed
the
max-trace-size-2
branch
from
84d5c03 to
5694c37
Compare
Contributor
Author
|
closed and reopened to re-run some failing checks. |
2. remove same code at aggregator.go 3. remove skipCurrentTrace and do an early exit from mergeTraces if the current count is already at max 4. remove redundant checks at aggregator.go Signed-off-by: Parship Chowdhury <[email protected]>
2. use range with .All() in copySpansUpToLimit 3. argument order to (dest, src, ...) Signed-off-by: Parship Chowdhury <[email protected]>
Signed-off-by: Parship Chowdhury <[email protected]>
Parship12
force-pushed
the
max-trace-size-2
branch
from
df74359 to
5b73044
Compare
yurishkuro
requested changes
Jan 1, 2026
cmd/jaeger/internal/extension/jaegerquery/internal/querysvc/v2/querysvc/service.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Parship Chowdhury <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Parship Chowdhury <[email protected]>
…f copySpansUpToLimit, fix early return Signed-off-by: Parship Chowdhury <[email protected]>
Signed-off-by: Parship Chowdhury <[email protected]>
Metrics Comparison SummaryTotal changes across all snapshots: 0 Detailed changes per snapshotsummary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
|
Member
|
bummer, merge conflicts, please resolve |
4 tasks
Signed-off-by: Parship Chowdhury <[email protected]>
Contributor
Author
|
@yurishkuro PTAL |
yurishkuro
reviewed
Jan 26, 2026
| incomingCount := src.SpanCount() | ||
| // check if we can merge all spans without exceeding limit | ||
| if maxSize <= 0 || *spanCount+incomingCount <= maxSize { | ||
| resources := src.ResourceSpans() |
Member
There was a problem hiding this comment.
can you not just call MergeTraces?
| } | ||
| } | ||
|
|
||
| func mergeTraces(dest, src ptrace.Traces, maxSize int, spanCount *int) bool { |
Member
There was a problem hiding this comment.
Suggested change
| func mergeTraces(dest, src ptrace.Traces, maxSize int, spanCount *int) bool { | |
| func mergeTracesWithLimit(dest, src ptrace.Traces, maxSize int, spanCount *int) bool { |
Comment on lines
+136
to
+137
| // direct access to first span (if truncated, it must exist) | ||
| firstSpan := trace.ResourceSpans().At(0).ScopeSpans().At(0).Spans().At(0) |
Member
There was a problem hiding this comment.
you can do it safely (without this assumption) by using
for _, span := range jptrace.SpanIter(trace) {
AddWarnings(span, ...)
return
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
max_trace_sizeconfiguration parameter to limit spans per traceHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test