[cassandra] Add omitempty notation for KeyValue and marshaller/unmarshaller for TraceID#7867
Merged
yurishkuro merged 4 commits intojaegertracing:mainfrom Jan 19, 2026
Merged
Conversation
…r/unmarshaller for TraceId Signed-off-by: Manik Mehta <mehtamanik96@gmail.com>
Manik2708
commented
Jan 13, 2026
Comment on lines
+26
to
+33
| func (t TraceID) String() string { | ||
| traceIDHigh := binary.BigEndian.Uint64(t[:8]) | ||
| traceIDLow := binary.BigEndian.Uint64(t[8:]) | ||
| if traceIDHigh == 0 { | ||
| return fmt.Sprintf("%016x", traceIDLow) | ||
| } | ||
| return fmt.Sprintf("%016x%016x", traceIDHigh, traceIDLow) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
string function was previously dependent on ToDomain now we want to get rid of v1 models so I made it independent of ToDomain
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7867 +/- ##
==========================================
+ Coverage 95.49% 95.51% +0.01%
==========================================
Files 305 306 +1
Lines 16174 16195 +21
==========================================
+ Hits 15445 15468 +23
+ Misses 571 570 -1
+ Partials 158 157 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Metrics Comparison SummaryTotal changes across all snapshots: 0 Detailed changes per snapshotsummary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
|
yurishkuro
added
the
changelog:refactoring
yurishkuro
approved these changes
Jan 19, 2026
4 tasks
Manik2708
added a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 20, 2026
…rshaller for `TraceID` (jaegertracing#7867) ## Which problem is this PR solving? - Needed for: jaegertracing#7844 ## Description of the changes - Currently while writing snapshot tests for conversion, `TraceID` is abruptly formatted because of array representation of it. Unmarshaller/Marshaller will convert them to hex string. ## How was this change tested? - Unit Tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Manik Mehta <mehtamanik96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
FromDbModelandToDbModelto accept and returndbmodel.Span#7844Description of the changes
TraceIDis abruptly formatted because of array representation of it. Unmarshaller/Marshaller will convert them to hex string.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test