Conversation
jaenster
requested review from
Nishimura-Katsuo,
Zombenstein and
ryancrunchi
Nishimura-Katsuo
left a comment
Nishimura-Katsuo
left a comment
There was a problem hiding this comment.
I don't even know what's going on, lol.
| // Setup difficulty | ||
| if (HeartBeat.gameInfo.difficulty.toLowerCase() === 'highest') { | ||
| if (!Control.Hell.click() && !Control.Nightmare.click() && !Control.Normal.click()) { | ||
| print('Cant select dificulty, wtf?'); |
There was a problem hiding this comment.
dificulty / difficulty
| while (true) { | ||
| delay(1000); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
New line at the end of your file, jerk!
| }); | ||
|
|
||
| // Not sure what it presses, stolen from D2BotLead | ||
| LocationEvents.on(sdk.locations.Gateway, () => ControlAction.click(6, 436, 538, 96, 32)); |
There was a problem hiding this comment.
This seems like the right most "Cancel" button on the gateway selection screen.
|
|
||
| include("OOG.js") && include('common/Misc.js') && include('sdk.js') && include('polyfill.js') && include('common/prototypes.js'); | ||
| if (!FileTools.exists("data/" + me.profile + ".json")) DataFile.create(); | ||
| let nextGame = DataFile.getStats()['nextGame']; |
There was a problem hiding this comment.
We should set up some linting to standardize when to use let/const and other code smells.
zmanowar
left a comment
zmanowar
left a comment
There was a problem hiding this comment.
It would be nice to move these helper functions out into their own file. For instance locationTimeout is redefined in most of the .dbj files.
It seems like the majority of the content of this file should be the config at the top (which might also benefit from being broken out into a "default" config) and registering event handlers.
However, it's outside of the scope of this PR to do that.
4 participants
Basically a modern copy of the D2BotLead.
@Nishimura-Katsuo / @ryancrunchi / @Zombenstein Could any of you review? Thanks =)