Refactor/music command #1534
Open
Refactor/music command #1534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e a complex method and decomposed a complex condition in the music command to improve code readability and maintainability.
…educe feature envy and improve encapsulation. The method was more dependent on Bot's functionality, making it more appropriate to be housed within the Bot class.
Location: JMusicBot class Rationale: Move the RECOMMENDED_PERMS variable to a superclass where it can be shared among multiple classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-For my current university course assignment, I need to improve the code by cleaning it up and making it easier to understand and modify (refactoring) whenever it's appropriate. This pull request focuses on refactoring the codebase to improve readability, maintainability, and performance. The changes include various refactorings aimed at cleaning up the code, making it easier to understand, and facilitating future modifications.
Purpose
The purpose of this pull request is to enhance the codebase by applying several refactoring techniques. These improvements will help streamline development, reduce technical debt, and make the codebase more robust and scalable for future iterations and maintenance.