bump to php7.4 #24
Open
bump to php7.4 #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi, James, any chance you can take a look at this? In particular, I don't know why the search test fails, I removed the 2 tests, but obviously that's not the right approach. Thx. |
jaimz22
requested changes
Sep 29, 2022
|
|
||
| namespace VertigoLabs\DoctrineFullTextPostgres\Common; | ||
|
|
||
| use App\Entity\Media; |
Comment on lines
+101
to
+110
| // $this->checkWatchFields($class, $prop, $attribute); | ||
| // $metaData->mapField([ | ||
| // 'fieldName' => $prop->getName(), | ||
| // 'columnName' => $this->getColumnName($prop, $annotation), | ||
| // 'type' => 'tsvector', | ||
| // 'weight' => strtoupper($annotation->weight), | ||
| // 'language' => strtolower($annotation->language), | ||
| // 'nullable' => $this->isWatchFieldNullable($class, $annotation) | ||
| // ]); | ||
|
|
Owner
There was a problem hiding this comment.
Commented out code should be removed
| foreach ($prop->getAttributes() as $reflectionAttribute) { | ||
| if ($reflectionAttribute->getName() === TsVector::class) { | ||
| // /** @var TsVector $attribute */ | ||
| $attribute = new ($reflectionAttribute->getName())(...$reflectionAttribute->getArguments()); // crazy, something is wrong here. |
Owner
There was a problem hiding this comment.
I'm a little apprehensive about this comment!
Contributor
Author
There was a problem hiding this comment.
No doubt! I'll see if I can figure it out. I'm fighting a little bit with supporting both attributes and annotations, I think that attributes should take priority if both exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests aren't working yet.
The current 'master' branch has a minimum stability of 'dev'. I think before this PR is accepted, perhaps you could drop that line, make sure everything runs, then tag is as 1.0, so anyone currently using it has a safe way of keeping it.
Alternatively, maybe create another branch and merge these changes in?
I'm not actually that familiar with how to use tsvector and such, which is why I used this bundle. So if you can fix the tests, I can clean up the code deprecations and such.
Thanks.