Skip to content

Change triggers #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: add-permissions
Choose a base branch
from
Open

Change triggers #26

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e63b4c
test pr change
jaisnan Jul 10, 2024
2852d9b
Remove relevance checks
jaisnan Jul 10, 2024
6e79e30
check with explicit write permissions
jaisnan Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 9 additions & 22 deletions .github/workflows/pr_approval.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,22 @@ name: Check PR Approvals
# To protect against that scenario, we can turn on number of approvals required to 2 in the github settings
# of the repository
on:
pull_request_review:
types: [submitted]
workflow_dispatch:
pull_request:
# pull_request_review:
# types: [submitted]
# workflow_dispatch:

# Without these permissions, we get a 403 error from github
# for trying to modify the pull request for newer project.
# Source: https://stackoverflow.com/a/76994510
permissions: write-all
permissions:
contents: write
actions: write
pull-requests: write
checks: write

jobs:
check-approvals:
if: github.event.review.state == 'APPROVED' || github.event_name == 'workflow_dispatch'
runs-on: ubuntu-latest
steps:
- name: Checkout repository
Expand Down Expand Up @@ -51,23 +55,6 @@ jobs:
pull_number = context.issue.number;
}

// Get PR files
const files = await github.rest.pulls.listFiles({
owner,
repo,
pull_number
});

const relevantPaths = ['library/', 'doc/src/challenges/'];
const isRelevantPR = files.data.some(file =>
relevantPaths.some(path => file.filename.startsWith(path))
);

if (!isRelevantPR) {
console.log('PR does not touch relevant paths. Exiting workflow.');
return;
}

// Get parsed data
try {
const tomlContent = fs.readFileSync('.github/pull_requests.toml', 'utf8');
Expand Down