-
Notifications
You must be signed in to change notification settings - Fork 34
Replace JDQL with JCQL #1315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace JDQL with JCQL #1315
Conversation
|
Because I haven't seen any reviews come in yet, I have also added the commit to remove JDQL from Jakarta Data and update documentation about it to refer to Jakarta Query, with the only parts remaining being the extra requirements that Jakarta Data impose and allowances that it makes for NoSQL. Please review this when you have a chance. It would be nice to get this in before the next milestone goes out. |
|
Mmmm. I guess I can't think of a good reason to delay this. |
| /** | ||
| * <p>Specifies the query executed by the annotated repository method, | ||
| * in JDQL or JPQL.</p> | ||
| * in JCQL or JPQL.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@njr-11 shall we use Jakarta Query here?
I mean, on this case it will run any of the languages of the query spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Jakarta Query adds additional language levels, we might or might not be able to support them in Jakarta Data. We would want to assess each on a case by case basis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh ok, good point.
First steps of #1314 to contribute Jakarta Data Query Language to Jakarta Query: