End MIME boundary should be followed by CRLF#580
Open
joshihirenn wants to merge 2 commits intojakartaee:masterfrom
Open
End MIME boundary should be followed by CRLF#580joshihirenn wants to merge 2 commits intojakartaee:masterfrom
joshihirenn wants to merge 2 commits intojakartaee:masterfrom
Conversation
The present code mandates that a CRLF is present after intermediate MIME boundary (that starts with --). This change extends that behaviour for end boundary too (that starts and ends with --). This is useful for processing some bulk emails that uses a single dash character as a boundary and a line full of dashes is present in the content. Gmail and Outlook are able to process such emails, however JavaMail truncates the email after the sequence of five dash characters are consumed from the line full of dash characters.
No all messages have epilogue. So an end MIME boundary may be followed by EOF.
lukasj
reviewed
Sep 17, 2021
Contributor
lukasj
left a comment
lukasj
left a comment
There was a problem hiding this comment.
Can you add a test (simple junit is fine) for this as well, please?
Author
|
Author
Sure, I will try to add one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The present code mandates that a CRLF is present after intermediate MIME boundary (that doesn't end with --). This change extends that behaviour for end boundary too (that starts and ends with --).
This is useful for processing some bulk emails that uses a single dash character as a boundary and a line full of dashes is present in the content. Gmail and Outlook are able to process such emails, however JavaMail truncates the email after the sequence of five dash characters are consumed from the line full of dash characters.
Signed-off-by : The author is aware of the terms by which the contribution has been provided to the project.