Handle comments in angled address specs in InternetAddress.parse()#764
Open
chu3laman wants to merge 1 commit intojakartaee:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InternetAddress.parse() fails to handle comments (text) within angled address specifications <email@domain.com (comment)>. The main parsing loop correctly skips comments, but the angled address parser (inside case '<':) lacks comment handling, causing comments to be treated as part of the email address.
Fix: Add comment parsing logic to the angled address parser, mirroring the existing comment handling in the main parsing loop. This ensures comments within < > are properly skipped and not included in the final email address.