Custom mail providers distributed under META-INF/javamail.properties are no longer loaded with Jakarta Mail 2.1.5#817
Open
jbescos wants to merge 1 commit intojakartaee:masterfrom
Open
Custom mail providers distributed under META-INF/javamail.properties are no longer loaded with Jakarta Mail 2.1.5#817jbescos wants to merge 1 commit intojakartaee:masterfrom
jbescos wants to merge 1 commit intojakartaee:masterfrom
Conversation
jbescos
force-pushed
the
issue812
branch
2 times, most recently
from
cf42970 to
c71b0db
Compare
jbescos
commented
Oct 2, 2025
| public synchronized void addProvider(Provider provider) { | ||
| providers.add(provider); | ||
| providersByClassName.put(provider.getClassName(), provider); | ||
| if (!providersByClassName.containsKey(provider.getClassName())) |
Member
Author
There was a problem hiding this comment.
I found this part a bit confusing. We now need this to prevent Jakarta resource overwriting JavaMail. But if we were already performing this check in providersByProtocol, why wasn’t it added here earlier?
…are no longer loaded with Jakarta Mail 2.1.5 jakartaee#812 Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#812
This could be handy for this review. It contains the changes when only jakarta files were going to be loaded.
Draft for now. I need to check more things.