Skip to content

Skip "null" values in role members during update #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip "null" values in role members during update #804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Bonobo.Git.Server/Data/Update/ADBackend/UpdateADBackend.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,12 @@ private static void UpdateRoles(string dir, Dictionary<string, Models.UserModel>
var members = new List<Guid>();
foreach (var memberName in role.Members)
{
if (memberName == null)
{
Log.Warning("Role {0} in file {1} contained member with value \"null\". Skipping this member.", role.Name, dir);
continue;
}

Models.UserModel user;
if (users.TryGetValue(memberName, out user))
{
Expand Down