Skip to content

refactor: use channelPoint as uniqueId by replacing colon with hyphen #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yemmyharry wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: use channelPoint as uniqueId by replacing colon with hyphen #1362

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb91e47
refactor: use channelPoint as uniqueId by replacing colon with hyphen
yemmyharry Feb 28, 2026
e74a7b3
test: add unit tests for LND channel mappers
yemmyharry Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/lib/lightning/lnd/mappers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,10 @@ import { PendingChannel } from 'shared/lndDefaults';
import { LightningNodeChannel } from 'lib/lightning/types';
import { snakeKeysToCamel } from 'utils/objects';

const txid = (channelPoint: string) => channelPoint.split(':')[0];

export const mapOpenChannel = (chan: LND.Channel): LightningNodeChannel => {
return {
pending: false,
uniqueId: txid(chan.channelPoint).slice(-12),
uniqueId: chan.channelPoint.replace(':', '-'),
channelPoint: chan.channelPoint,
pubkey: chan.remotePubkey,
capacity: chan.capacity,
Expand All @@ -25,7 +23,7 @@ export const mapPendingChannel =
(status: LightningNodeChannel['status']) =>
(chan: PendingChannel): LightningNodeChannel => ({
pending: true,
uniqueId: txid(chan.channelPoint).slice(-12),
uniqueId: chan.channelPoint.replace(':', '-'),
channelPoint: chan.channelPoint,
pubkey: chan.remoteNodePub,
capacity: chan.capacity,
Expand Down