Skip to content

Comments

fix: Support Django 5.2 LTS#325

Merged
jambonrose merged 16 commits intojambonrose:developmentfrom
justinmayer:django-5.2
Feb 15, 2026
Merged

fix: Support Django 5.2 LTS#325
jambonrose merged 16 commits intojambonrose:developmentfrom
justinmayer:django-5.2

Conversation

@justinmayer
Copy link
Contributor

  • Support Django 5.2 LTS
  • Test on Python 3.14 in CI
  • Drop support for EOL Python 3.8 & 3.9
  • Upgrade GitHub Actions to latest versions

The `BaseUserManager.make_random_password()` method was deprecated in
Django 4.2 and completely removed in Django 5.1, causing a test error
on Django 5.2 and higher. This change adds the `make_random_password()`
method to the UserManager class in order to resolve this error.
Django 5.0+ changed the logout view to no longer accept GET requests and
only accept POST requests for security reasons:
https://code.djangoproject.com/ticket/15619
In Django 5.x, the `last_login` and `date_joined` datetime fields were
being treated as changed even when not modified, causing tests to fail.

These fields should not be manually editable, since `last_login` is
automatically updated when a user logs in, and `date_joined` is set on creation.

This changes these two fields in the UserAdmin class to be read-only,
which prevents these fields from being included in form submissions
and ensures they are displayed as read-only in the admin interface.
@justinmayer
Copy link
Contributor Author

Hey Andrew! I made some changes to support Django 5.2 LTS. I see something about token-less CodeCov uploads not being supported in forked repositories; I don't use CodeCov and thus don't know anything about resolving that.

Aside from that, could you please review the changes and let me know what else is needed to get this merged?

@jambonrose
Copy link
Owner

@justinmayer , thank you very much for the work and the PR!

I see the codecov issue. I'm going to push directly to this branch to see if I can ensure future pull-requests can benefit from coverage data.

@codecov
Copy link

codecov bot commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100%. Comparing base (a943e4c) to head (855c988).
⚠️ Report is 1 commits behind head on development.

Additional details and impacted files
@@            Coverage Diff             @@
##           development   #325   +/-   ##
==========================================
  Coverage          100%   100%           
==========================================
  Files                9      9           
  Lines              173    177    +4     
  Branches             9      9           
==========================================
+ Hits               173    177    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jambonrose jambonrose self-requested a review February 15, 2026 14:03
@jambonrose jambonrose added the Type: Dependency Upgrade PR upgrades dependencies. label Feb 15, 2026
Copy link
Owner

@jambonrose jambonrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jambonrose jambonrose merged commit ba89888 into jambonrose:development Feb 15, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Dependency Upgrade PR upgrades dependencies.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants