Support for :unless, passing attributes, parametrizing :event_class_name, and cleanup#11
Open
onedesign wants to merge 15 commits intojamesgolick:masterfrom
Open
Support for :unless, passing attributes, parametrizing :event_class_name, and cleanup#11onedesign wants to merge 15 commits intojamesgolick:masterfrom
onedesign wants to merge 15 commits intojamesgolick:masterfrom
Conversation
timeline_fu should be much easier to develop against now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
We recently introduced
timeline_fuinto a project, and made some changes which we think would be helpful for everyone.This fork was based off
szajbus/timeline_fuand incorporates their features, which came in handy.It also adds support for specifying
:event_class_name, soTimelineEventis not hardcoded, as well as specifying more than one event class. This is helpful in situations where tracking for events byCommentshould be handled byCommentEventand be separate fromPost, which is handled byPostEvent, for example. We also found it helpful to specify:event_class_name => ["CommentEvent", "UserEvent"], thus being able to easily build an audit log for a particular Comment, as well as an entire activity log for a User.Finally, we cleaned up the gemspec and added the gem’s dependencies to it, introduced bundler, and appraisal, so the gem is now tested against the latest stable version of
ActiveRecord2.3.x,3.0.x, and3.1.x(all tests currently pass, of course)We hope you approve and thanks for starting
timeline_fu!Cheers,
The folks at One Design Company