Various fixes and improvements#6
Open
cs wants to merge 10 commits intojamesgolick:masterfrom
cs:master
Open
Conversation
Conflicts: generators/timeline_fu/templates/migration.rb
…stem. replace `has_entry` with "full" expectations to fix the issue (same technique as in other tests).
…l. support for passing `:account` fires. tests are up to date as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gititnoreall*.rbcfiles (generated by rubinius)has_entrymethod is undefined on my system. replacehas_entrywith "full" expectations to fix the issue (same technique as in other tests). note:has_entryis supposed to be defined inmocha.belongs_to :accountto timeline event incl. support for passing:accountto the fires macro. tests are up to date as well.hope you like it! thanks!