forked from ExeClim/Isca
-
Notifications
You must be signed in to change notification settings - Fork 0
Two Stream Bug Fix Test #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jamesp
wants to merge
18
commits into
master
Choose a base branch
from
two_stream_bug_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/extra/python/isca/util.py
Removed p_levs == 'MODEL' option and added an exception in case of invalid string input
I think this ampersand is a (possibly silent) bug in moist_phys. ifort seems to skip over it, but gfortran fails to compile. **I HAVE NOT YET VERIFIED BITWISE RESULTS AFTER REMOVING THIS**
Bug fix in idealized_moist_phys
Command syntax for running the debugger to make life a little simpler...
For got to add how to print the variables current state.
Formatting changes to run_isca readme
…use if dt_rad wasn't set in the namelist then it defaulted to 0, and so seg-faulted everything. Now added initialisation step to default dt-rad to dt-atmos if dt-rad isn't set.
Merge latest master changes into sit master
RRTM dt-rad bug-fix
Add sensible heat flux description
Update FieldNames.md
array lw_dtrans_win is only used in the B_GEEN scheme, and is only allocated when `lw_scheme == B_GEEN` (line 278). Therefore at line 517 `lw_dtrans_win` is potentially unallocated. Moved this assignment into the B_GEEN scheme guard at line 528. All other changes are whitespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.