This repository was archived by the owner on Aug 23, 2022. It is now read-only.
Add JavaScript flag support #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonny-bull
force-pushed
the
javascript-flags
branch
2 times, most recently
from
a13f535 to
577e14c
Compare
Owner
|
Hey @jonny-bull thanks again for putting your time and effort into this PR. Looks awesome and I think it is a super useful feature addition so thank you! My only question is around if we want to "offically" bump the minimum PHP version up in flagpole.php#L17 to match the new syntax used in |
jonny-bull
force-pushed
the
javascript-flags
branch
from
97b915f to
2990ec4
Compare
Author
|
Just like on the other PR, apologies for the delay but this is updated to support PHP 5.6 |
jonny-bull
force-pushed
the
javascript-flags
branch
2 times, most recently
from
f736556 to
20cf02f
Compare
jonny-bull
force-pushed
the
javascript-flags
branch
from
b60e8d0 to
a8277cb
Compare
jonny-bull
force-pushed
the
javascript-flags
branch
from
d45587e to
8b1286c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #14
Allows for use of the same
flagpole_flag_enabledfunction in JavaScript as used in PHP.Also some minor PHPCS fixes to the flagpole.php file.