Skip to content

feat: new option to turn gallery generation off #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: new option to turn gallery generation off #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09df54e
feat: new option to turn gallery generation off
mojoaxel Jan 31, 2017
808b058
feat: return max mismatch to callback
mojoaxel Jan 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/wraith.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ Wraith.prototype.config = function(config) {
self.sizes = [];
self.dirs = [];
self.quiet = config.quiet || false;
self.gallery = config.hasOwnProperty('gallery') ? config.gallery : true;
self.server = {};
self.server.start = config.server.start || false;
self.server.port = config.server.port || 9090;
Expand Down Expand Up @@ -239,6 +240,7 @@ Wraith.prototype.compareScreenshots = function() {
}

self.compareQueue = [];
self.maxMismatch = 0;

for(var url in self.urls) {
var dir = self.urls[url].substring(1).replace(/\/+$/,'') + '/';
Expand Down Expand Up @@ -277,6 +279,7 @@ Wraith.prototype.compareScreenshots = function() {
async.eachLimit(self.compareQueue, self.maxConnections, function(task, callback) {
resemble('./' + task.base).compareTo('./' + task.compare).ignoreAntialiasing().onComplete(function(data) {
data.getDiffImage().pack().pipe(fs.createWriteStream(task.output));
self.maxMismatch = data.misMatchPercentage > self.maxMismatch ? data.misMatchPercentage : self.maxMismatch;
fs.writeFile('./' + task.diff, data.misMatchPercentage, function(err) {
if(err) { log.error(err); }
if(bar) {
Expand All @@ -293,7 +296,13 @@ Wraith.prototype.compareScreenshots = function() {
return self;
} else {
log.success('Image comparison done');
self.generateGallery();
if (self.gallery || self.server.start) {
self.generateGallery();
} else {
helpers.emptyFolder(self.outputFolder, function() {
self.cb(self.maxMismatch);
});
}
return self;
}
});
Expand Down