chore(dependencies): Update all dependencies#55
chore(dependencies): Update all dependencies#55jamesvillarrubia wants to merge 1 commit intomainfrom
Conversation
📝 WalkthroughWalkthroughThe pull request updates devDependencies in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
🔇 Additional comments (2)
package.json (2)
24-24: The ESLint 9 dependency update does not require configuration changes in this project. ESLint is in devDependencies but is not referenced in any npm scripts, and no ESLint configuration files exist in the codebase. The update is safe as-is.Likely an incorrect or invalid review comment.
14-34: All verified package versions exist on npm with no known security vulnerabilities. The @feathersjs packages (5.0.37) are patched against CVE-2023-37899 (fixed in 5.0.8+), and eslint@9.39.2 is unaffected by CVE-2025-54313 (which targeted eslint-config-prettier).
| "release-it": "^17.6.0", | ||
| "f5": "npm:@feathersjs/feathers@^5.0.37", | ||
| "f5_exp": "npm:@feathersjs/express@^5.0.37", | ||
| "mocha": "^11.7.5", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Mocha 11 breaking changes release notes
💡 Result:
Mocha 11 — main breaking change: the minimum Node.js engine requirement was raised (Mocha 11 updates the engine range; v11.0.0 published Nov 11, 2024). (classic.yarnpkg.com)
Citations:
🌐 Web query:
Mocha 11 minimum Node.js version requirement
💡 Result:
Mocha 11 requires Node.js >= 18.18.0 (minimum Node.js version bumped to 18.18.0). [1][2]
Sources:
- Mocha 11 release plan / versioning note. [1]
- Mocha documentation (getting started / installation) referencing Node.js requirements. [2]
🏁 Script executed:
cat package.json | jq '.engines' 2>/dev/null || echo "No engines field found"Repository: jamesvillarrubia/feathers-rpc
Length of output: 97
Update Node.js engine requirement to match Mocha 11.
Mocha 11 requires Node.js >= 18.18.0, but your package.json specifies "node": ">=14.0.0". Update the engines.node field to ">=18.18.0" to ensure compatibility with Mocha 11, or downgrade Mocha to a version that supports Node.js 14.
🤖 Prompt for AI Agents
In package.json around line 29, the engines.node field currently allows
">=14.0.0" but Mocha 11 requires Node.js >=18.18.0; update the "engines.node"
value to ">=18.18.0" (or alternatively downgrade the mocha dependency to a Node
14–compatible version) so the declared Node.js requirement matches Mocha's
minimum supported version and prevents runtime incompatibilities.
| "f5": "npm:@feathersjs/feathers@^5.0.37", | ||
| "f5_exp": "npm:@feathersjs/express@^5.0.37", | ||
| "mocha": "^11.7.5", | ||
| "nyc": "^17.1.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
NYC npm package version 17.1.0 breaking changes migration guide
💡 Result:
Summary of breaking changes and migration steps for nyc 17.1.0
-
What changed
- 17.1.0 is a minor bump that mainly updates dependencies (notably foreground-child to v3) and reduces serialized JSON output size. (classic.yarnpkg.com)
- The breaking change affecting users was introduced in 17.0.0: minimum supported Node.js version is now Node 18 (so any upgrade to >=17.x requires Node ≥18). (classic.yarnpkg.com)
-
Migration checklist (minimal)
- Ensure your environment and CI use Node.js >= 18 (update runtime images, CI matrix, and engines field if you pin it). (classic.yarnpkg.com)
- Run your test/coverage pipeline with nyc 17.1.0 locally and in CI; expect only dependency/serialization changes — verify any tooling that parses nyc’s JSON output still works (serialized JSON size was reduced). (classic.yarnpkg.com)
- If you vendor or patch nyc’s dependencies, note foreground-child was bumped to v3; confirm no incompatibilities in your environment. (classic.yarnpkg.com)
- Pin nyc in package.json (npm i nyc@17.1.0) and run full test suite; fix any Node-18-related runtime issues (e.g., dropped legacy APIs). (npmjs.com)
-
Links / sources
- nyc changelog / release notes (shows 17.1.0 notes and 17.0.0 breaking change). (classic.yarnpkg.com)
- Package metadata / docs for 17.1.0. (jsdocs.io)
If you want, I can:
- produce a CI config snippet (GitHub Actions / GitLab) to ensure Node 18+ during tests, or
- run a quick diff of nyc 16.x/17.x public API calls in your repo if you paste your nyc config or scripts.
Citations:
- 1: https://classic.yarnpkg.com/en/package/nyc?utm_source=openai
- 2: https://classic.yarnpkg.com/en/package/nyc?utm_source=openai
- 3: https://classic.yarnpkg.com/en/package/nyc?utm_source=openai
- 4: https://classic.yarnpkg.com/en/package/nyc?utm_source=openai
- 5: https://classic.yarnpkg.com/en/package/nyc?utm_source=openai
- 6: https://www.npmjs.com/package/nyc/v/10.1.0?activeTab=versions&utm_source=openai
- 7: https://classic.yarnpkg.com/en/package/nyc?utm_source=openai
- 8: https://www.jsdocs.io/package/nyc?utm_source=openai
🏁 Script executed:
# Check package.json for Node.js version requirements and previous nyc version
cd /tmp/repo 2>/dev/null || cd .
# Show relevant parts of package.json
head -50 package.json | cat -nRepository: jamesvillarrubia/feathers-rpc
Length of output: 1953
🏁 Script executed:
# Search for any references to nyc configuration, JSON parsing, or Node version requirements
rg -i "node.*version|engines|nyc" package.json -A 2 -B 2Repository: jamesvillarrubia/feathers-rpc
Length of output: 610
🏁 Script executed:
# Look for .nycrc or other NYC config files
fd -e nycrc -e nycrc.json -o "\.nycrc*"Repository: jamesvillarrubia/feathers-rpc
Length of output: 208
🏁 Script executed:
# Search for any code that parses NYC output
rg -i "nyc.*json|coverage.*json" --type js --type ts -lRepository: jamesvillarrubia/feathers-rpc
Length of output: 55
Update engines.node to >=18.0.0 to support NYC 17.1.0.
NYC 17.1.0 requires Node.js 18 or higher (breaking change introduced in 17.0.0). The engines.node field is currently set to >=14.0.0 and must be updated to >=18.0.0 to match this requirement. Without this change, projects running on Node 14–17 will fail at runtime when installing and using NYC.
🤖 Prompt for AI Agents
In package.json around line 30, the engines.node field currently allows
">=14.0.0" but NYC 17.1.0 requires Node >=18.0.0; update the "engines.node"
entry to ">=18.0.0" (and any related CI/runtime config that enforces node
version, e.g., .nvmrc, engines-strict, or Dockerfiles) so that installs on Node
14–17 no longer proceed and the project aligns with NYC 17.1.0's minimum Node
requirement.
1 participant
Summary by CodeRabbit
Chores
✏️ Tip: You can customize this high-level summary in your review settings.