Conversation
…d OS and remove remaining Big Sur things
team-adder
bot
requested review from
SchiefLaut,
kleistdj,
pmoprhy,
seth-w-gilbert,
watkyn and
zachalmberg
|
@copilot review this |
There was a problem hiding this comment.
Pull request overview
This PR removes Big Sur-era compatibility paths now that the app targets newer macOS versions, standardizing PPPC payload generation on the modern Authorization key and cleaning up related UI, model logic, and resources.
Changes:
- Remove the Big Sur compatibility toggle and the legacy
Allowed-key export path; always emitAuthorization. - Delete the URLSession async/await compatibility shim and rename the PPPC services JSON flag to
allowStandardUsers. - Update docs/changelog for macOS 13+ requirement and enhance CI to collect/display code coverage.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Source/Networking/URLSessionAsyncCompatibility.swift | Removes the deprecated async URLSession compatibility extension. |
| Source/Model/PPPCServiceInfo.swift | Renames decoded JSON field to allowStandardUsers. |
| Source/Model/Model.swift | Removes legacy allow-key switch logic; always maps UI values to authorization. |
| Resources/PPPCServices.json | Renames allowStandardUsersMacOS11Plus to allowStandardUsers. |
| Resources/Base.lproj/Main.storyboard | Removes the “Big Sur Compatibility” UI toggle and rewires constraints/outlets accordingly. |
| README.md | Updates stated minimum supported macOS version to 13.0+. |
| CHANGELOG.md | Notes macOS 13+ requirement and removal of legacy Allowed support. |
| .github/workflows/tests.yml | Enables code coverage and adds a coverage summary display step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [logo]: /Resources/Assets.xcassets/AppIcon.appiconset/PPPC_Logo_32%402x.png "PPPC Utility" | ||
|
|
||
| PPPC Utility is a macOS (10.15 and newer) application for creating configuration profiles containing the Privacy Preferences Policy Control payload for macOS. The profiles can be saved locally, signed or unsigned. Profiles can also be uploaded directly to a Jamf Pro server. | ||
| PPPC Utility is a macOS (13.0 and newer) application for creating configuration profiles containing the Privacy Preferences Policy Control payload for macOS. The profiles can be saved locally, signed or unsigned. Profiles can also be uploaded directly to a Jamf Pro server. |
There was a problem hiding this comment.
yeah, and maybe we make even a little bigger jump since apple only really supports back to macOS 14.
| - Now using [Haversack](https://github.com/jamf/Haversack) for simplified access to the keychain ([Issue #124](https://github.com/jamf/PPPC-Utility/issues/124)) [@macblazer](https://github.com/macblazer). | ||
| - PPPC Utility now requires macOS 11+ to run. It can still produce profiles usable on older versions of macOS. | ||
| - PPPC Utility now requires macOS 13+ to run. It can still produce profiles usable on older versions of macOS. | ||
| - Removed Big Sur compatibility toggle and legacy `Allowed` key support. The `Authorization` key is now always used. |
There was a problem hiding this comment.
If we are jumping from 11 to 13, we'd be removing Monterey too, right?
There was a problem hiding this comment.
The Big Sur compatibility feature was a backward compatibility thing specific to the how we build the config profile.
The first bullet is about what version of macOS the app can run on. The second bullet refers specifically to that feature that was removed.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
No description provided.