Open
Conversation
Otherwise it's impossible to disable storing the state of the slide.
Author
|
If I missed something and we need this to be stored during the current session (maybe some re-render?) could we switch to |
Owner
|
Without local storage the presenter doesn't stay in sync. The real solution is to send messages somehow instead. |
Author
|
Ohh that's what it's for! That makes sense, hmm... |
|
@mxstbr You could try adding a export default class Presentation extends React.Component {
constructor(props) {
super(props);
localStorage.clear();
}
render() { /* ... */ }
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found myself going on stage, starting my presentation in front of my crowd and all of my code slides being at the wrong location because their state was stored to
localStorage.I can't think of a reason I'd want to keep the state of the slides between practice runs and the real deal, so I've added a prop to disable that behaviour. (
localStorage, with the default being the current behaviour)