-
Notifications
You must be signed in to change notification settings - Fork 240
Manage client-side channels locally, own channel always 0 #3426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
55ee809
Unchain signals via CClient for future ID mapping
softins 16fcf1b
Add some placeholder comments for changes needed
softins 7f10dff
Add data and methods for managing client channels
softins 144c1eb
Add join sequence, init and info messages
softins 49eb608
Do mapping between server and client channels
softins 5d31dd1
Added protection against deletion of our own channel
softins d26bbd8
Add entries to CClientChannel for gain and level
softins f8d1e68
Added reordering of received level list by client channel
softins 85ceaaf
Clear channel list if server has restarted
softins b950e09
Update Sort Users by Channel menu entry
softins 42faa26
Use oldGain and newGain in clientChannels[]
softins 75792ae
Fix for clang-format
softins 2d15a81
Rename action for Sort by Channel
softins 1791c43
Add explanatory comment to CClient::ReorderLevelList()
softins d386e05
Remove unneeded TODO comment and add clarification
softins 4b56a8c
Clarify boolean result of ReorderLevelList()
softins 6a27126
Minor updates from review comments
softins 4b8b733
Update src/client.cpp
softins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.