Re add pinning to create-dmg #3511
Conversation
| - name: create-dmg | ||
| changelog_name: create-dmg (macOS) | ||
| get_upstream_version: GH_REPO=create-dmg/create-dmg gh release view --json tagName --jq .tagName | sed -re 's/^v//' | ||
| local_version_regex: (.*CREATEDMG_?VERSION_?TAG\s*=\s*"?)([0-9.]*)("?.*) |
There was a problem hiding this comment.
| local_version_regex: (.*CREATEDMG_?VERSION_?TAG\s*=\s*"?)([0-9.]*)("?.*) | |
| local_version_regex: (.*CREATEDMG_?VERSION_?TAG\s*=\s*"?)(v[0-9.]*)("?.*) |
(not sure)
There was a problem hiding this comment.
Maybe v? then?
Where is it used?
| fi | ||
| brew install "${pkg_version}--"* | ||
| pushd "${dependency_root_folder}" | ||
| sudo make install |
There was a problem hiding this comment.
This makes the function somewhat not portable.
There was a problem hiding this comment.
But this code doesn't need to be portable to a non-Mac. And I assume all Macs will have sudo?
There was a problem hiding this comment.
Yes. All Macs should have sudo. I just want to make clear that dependencies which don't need make install would need a different function
softins
left a comment
softins
left a comment
There was a problem hiding this comment.
I'm happy with this. I made a branch of my own from it with added logging and ran the autobuild twice. The first time it successfully fetched create-dmg and built it. The second time it picked up the cached create-dmg. I then installed the built artifact and it ran ok.
ann0see
force-pushed
the
autobuild/reAddCreateDmgPin
branch
from
51d29ab to
157cc00
Compare
| # FIXME: Currently caching is disabled due to an error in the extract step | ||
| brew install create-dmg | ||
| # Install create-dmg | ||
| github_install_dependency "create-dmg/create-dmg" "v${CREATEDMG_VERSION}" |
There was a problem hiding this comment.
Changed this to use the version instead of the tag here...
3 participants
Short description of changes
Moves away from brew to now use native github downloads and installs from create-dmg. Also adds (yet untested) auto updates.
Fixes: #3152
CHANGELOG: SKIP
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Test if caching worksIt does. But Qt caching fails - but that's unchanged.Checklist
AUTOBUILD: Please build all targets