-
Notifications
You must be signed in to change notification settings - Fork 238
Add Japanese translation (ja_JP) #3568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Japanese translation (ja_JP) #3568
Conversation
This adds a complete Japanese translation for the Jamulus client application. Based on Korean (ko_KR) translation template, all strings have been translated to Japanese for better localization support. Related Issue: jamulussoftware#3567
| <message> | ||
| <location filename="../audiomixerboard.cpp" line="254"/> | ||
| <source>Grp</source> | ||
| <translation>グループ</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be too long. Would need to be checked in the compiled version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know Japanese, but from what Google shows, maybe 组 might work, and be shorter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just looked, and this text is only used in "Normal" mixer style. There is room for the original suggested translation and optional group number.
Only the "Normal" style appears to have translations for Grp, Mute and Solo. The "Fancy" style lacks similar translations for GRP, MUTE and SOLO. The "Compact" style only uses initials G, M and S, but they are available for translation if desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know Japanese, but from what Google shows, maybe 组 might work, and be shorter?
I can reveal that I have a degree in Japanese language :-) I'm pretty sure グループ would almost certainly be the preferred rendering in this context.
| <message> | ||
| <location filename="../audiomixerboard.cpp" line="224"/> | ||
| <source>PAN</source> | ||
| <translation>PAN</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe those also have a short version in ja_JP? (Same for MUTE, GRP etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly パン but not much shorter, and is may not be the convention in audio apps (not sure).
| </message> | ||
| <message> | ||
| <location filename="../clientdlg.cpp" line="178"/> | ||
| <source>The CPU of the client or server is at 100%.</source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth rephrasing in English... @gilgongo
Maybe use something like: The CPU of the client or server is overloaded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes (unless the code only indicates 100% and not, say, 99%? Or is it about load average, I get confused on that).
BTW (and not for this PR of course) the English phrasing of a lot the help text in the app is fairly inconsistent and could do with being in what's sometimes called "note form" for brevity. For example here it would be better as simply "Client or server CPU overloaded" or even "Client/server CPU overload".
| </message> | ||
| <message> | ||
| <location filename="../clientsettingsdlg.cpp" line="123"/> | ||
| <source>Under the Windows operating system the ASIO driver (sound card) can be selected using %1. If the selected ASIO driver is not valid an error message is shown and the previous valid driver is selected. Under macOS the input and output hardware can be selected.</source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should really be consistent with macOS instead of MacOS throughout the code...
But that's not your problem ;-)
softins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know Japanese, but I have built and run this code, and verified that there are no accelerator key conflicts in client or server, that I could see in Japanese mode.
This PR should also include an addition to util.cpp around line 560 to credit the translator for Japanese.
| <message> | ||
| <location filename="../audiomixerboard.cpp" line="254"/> | ||
| <source>Grp</source> | ||
| <translation>グループ</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know Japanese, but from what Google shows, maybe 组 might work, and be shorter?
| <message> | ||
| <location filename="../audiomixerboard.cpp" line="254"/> | ||
| <source>Grp</source> | ||
| <translation>グループ</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just looked, and this text is only used in "Normal" mixer style. There is room for the original suggested translation and optional group number.
Only the "Normal" style appears to have translations for Grp, Mute and Solo. The "Fancy" style lacks similar translations for GRP, MUTE and SOLO. The "Compact" style only uses initials G, M and S, but they are available for translation if desired.
Added tsukurun as the Japanese (ja_JP) translator in the credits section of util.cpp.
|
@softins Thanks for the suggestion! I've added the Japanese translator credit to util.cpp. |
softins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
| </message> | ||
| <message> | ||
| <source>For details on the contributions check out the </source> | ||
| <translation type="vanished">貢献の詳細については以下を確認してください </translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would コード貢献 be clearer? I know the English doesn't use "code contributions" but 貢献 might be a bit unclear?
| <message> | ||
| <location filename="../audiomixerboard.cpp" line="152"/> | ||
| <source>Shows a status indication about the client which is assigned to this channel. Supported indicators are:</source> | ||
| <translation>このチャンネルに割り当てられたクライアントのステータスを表示します。サポートされるインジケーター:</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
インディケーター is probably better.
…utions" Changed "貢献" to "コード貢献" for clearer context as suggested by gilgongo. - "貢献の詳細" → "コード貢献の詳細" - "Github 貢献者リスト" → "Github コード貢献者リスト" - "貢献者" → "コード貢献者"
|
@gilgongo Thanks for the feedback! I've updated "貢献" to "コード貢献" for clarity. The "インジケーター" spelling was already consistent throughout. |
|
Thank you all for reviewing and merging this PR! 🎉 Special thanks to @softins, @ignotus666, @gilgongo, and @ann0see for your helpful feedback and guidance throughout the review process. I'm excited to see Japanese translation included in Jamulus 3.12.0! |
お疲れ様でした! |
Summary
Related Issue
Closes #3567
Test
lrelease