Merged
Conversation
❯ ./vsdf --toy /Users/james/bar/testshaders/hills.frag dyld[38737]: Library not loaded: @rpath/libs/libglslang-default-resource-limits.16.dylib Referenced from: <E7C32331-7082-3DE7-8CE8-28F35DB57733> /Users/james/Desktop/v0.1.1/macos/vsdf Reason: tried: '/Users/james/Desktop/v0.1.1/macos/libs/libs/libglslang-default-resource-limits.16.dylib' (no such file), '/usr/local/lib/libs/libglslang-default-resource-limits.16.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/usr/local/lib/libs/libglslang-default-resource-limits.16.dylib' (no such file), '/opt/homebrew/lib/libs/libglslang-default-resource-limits.16.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/lib/libs/libglslang-default-resource-limits.16.dylib' (no such file), '/Users/james/Desktop/v0.1.1/macos/libs/libs/libglslang-default-resource-limits.16.dylib' (no such file), '/usr/local/lib/libs/libglslang-default-resource-limits.16.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/usr/local/lib/libs/libglslang-default-resource-limits.16.dylib' (no such file), '/opt/homebrew/lib/libs/libglslang-default-resource-limits.16.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/lib/libs/libglslang-default-resource-limits.16.dylib' (no such file) fish: Job 1, './vsdf --toy /Users/james/bar/t…' terminated by signal SIGABRT (Abort)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a hybrid rpath-based linking approach for release binaries, improving compatibility and reliability across different Linux distributions and macOS systems. The changes build upon #43 by bundling dependencies more comprehensively and adding automated testing on multiple platforms.
Changes:
- Updated Linux build to use ubuntu-latest with enhanced dependency bundling and rpath configuration
- Added automated testing jobs for Ubuntu 24.04 and Debian 13 to verify binary compatibility
- Enhanced macOS build with code signing and improved rpath handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #43 this generates release binaries with the hybrid rpath based linking approach