Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the project from using Git submodules to CMake's FetchContent for managing the Volk dependency. This approach simplifies the build process by removing the need for manual submodule initialization and updates.
Changes:
- Replaced Git submodule dependency management with CMake FetchContent for the Volk library
- Removed all submodule initialization steps from documentation and CI/CD workflows
- Updated Nix build configuration to remove manual Volk handling
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Added FetchContent configuration to automatically fetch Volk from GitHub and bumped minimum CMake version to 3.11 |
| .gitmodules | Removed Volk submodule configuration |
| default.nix | Removed manual Volk fetching and copying logic |
| README.md | Removed git submodule update commands from build instructions |
| QUICKSTART.md | Removed dedicated submodule initialization section |
| .github/workflows/*.yml | Removed submodules: recursive from checkout actions across all CI workflows |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if(NOT TARGET volk) | ||
| FetchContent_Declare( | ||
| volk | ||
| GIT_REPOSITORY https://github.com/zeux/volk.git |
There was a problem hiding this comment.
Consider adding a GIT_TAG to pin the Volk version for reproducible builds. Without a specific commit or tag, the build will fetch the latest version from the default branch, which could introduce breaking changes unexpectedly.
Suggested change
| GIT_REPOSITORY https://github.com/zeux/volk.git | |
| GIT_REPOSITORY https://github.com/zeux/volk.git | |
| GIT_TAG v1.3.275 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
FetchContentrather thangitsubmodules