Allow Overriding Reverse Proxy Configuration with Environment Variables#3369
Open
chtzvt wants to merge 1 commit intojaneczku:masterfrom
Open
Allow Overriding Reverse Proxy Configuration with Environment Variables#3369chtzvt wants to merge 1 commit intojaneczku:masterfrom
chtzvt wants to merge 1 commit intojaneczku:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
I recently encountered an identical issue to the problem described in #2401, and needed to implement a workaround that didn't rely on appending headers in the reverse proxy.
In my case, I use an opaque reverse proxy that isn't configurable, and I realized that others may encounter the same problem depending on their deployment scenario. Thus, this PR introduces an optional mechanism that allows the same set of configuration you'd otherwise apply in a reverse proxy's settings to be set with environment variables where calibre-web itself is hosted.
I can confirm that this works in my testing, as Kobo download links are generated properly and respect the overridden scheme, host, and port.
TL;DR
In addition to overriding request environment settings via
X-Schemeand similar headers, calibre web will now respect the following overrides via environment variables: