Add on-demand conversion to ePub to support in browser reading of other formats#3408
Open
akharlamov wants to merge 1 commit intojaneczku:masterfrom
Open
Add on-demand conversion to ePub to support in browser reading of other formats#3408akharlamov wants to merge 1 commit intojaneczku:masterfrom
akharlamov wants to merge 1 commit intojaneczku:masterfrom
Conversation
akharlamov
force-pushed
the
feat/convert-ondemand
branch
from
bb0335e to
fe8b4e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some libraries (including mine) have a large body of non-EPUB books. While it is possible to batch convert them to ePub, it is not efficient for multi-gigabyte libraries.
The PR adds a simple on-demand conversion functionality, so in-browser reading is available for FB2 and MOBI if Calibre binaries are available.
Implementation details:
A background task is started through WorkerThread. User is redirected to conversion page that reloads with 5 second interval and polls state of the task. On completion, the user is redirected to read_book page.