Epub reader adjustments: add Columns setting saving to localStorage (as per asking from comment)#3513
Open
IgorKurkov wants to merge 1 commit intojaneczku:masterfrom
Open
Epub reader adjustments: add Columns setting saving to localStorage (as per asking from comment)#3513IgorKurkov wants to merge 1 commit intojaneczku:masterfrom
IgorKurkov wants to merge 1 commit intojaneczku:masterfrom
Conversation
IgorKurkov
changed the title
Contributor
Author
|
the problem I encountered, a lot of the code for features, especially gestures has been removed (probably accidentally) in commit Merge Reader improvements - eb87286 Also I can't find hammer.min.js in next commits where it has been removed, because it is required for gestures. Did you guys removed it for some reason @OzzieIsaacs ? current code with pointstart pointend didnt work, thats why I added it, current code in master is broken anyway so we need to take a look into failed merge. it cause current conflict as far as it was happen because of vanishing current code. WIP, suggest to revert this commit, but this is a merge commit... so this is sort of problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi All
as an addition to this PR - #3475
I have added desired saving to localstorage for Columns one/two for user ronenrozner
please take a look, nothing special here, just handler and saving
and Happy New Year Everyone :)