Open
Conversation
- 【what】 add missing semicolon and text-overflow: clip to rule - 【why】 ensure consistent overflow handling and prevent layout bugs
- 【fix】 change height from fixed 30px to auto and reduce line-height - 【fix】 enable normal white-space and visible overflow - 【fix】 unset text-overflow and add overflow-wrap and word-break - 【fix】 prevent clipped link text for better responsiveness
- 【markup】 restructure shelf list to separate link, icon, and name - 【icon】 show globe for public and lock for private shelves - 【count】 compute shelf_len and hide badge when count is 1 - 【classes】 add shelf-link and shelf-name classes for easier styling
- 【feat】 sort shelves by is_public so private shelves appear first - improve shelf ordering to prioritize private content for users
- 【layout】prevent shelf icon from rendering for anonymous users - 【reason】only show lock/globe icon to authenticated users to avoid - confusing UI for unauthenticated visitors
- 【feat】 add title attribute to shelf links showing name and count ⚡️ perf(layout): compute shelf_len once to avoid duplicate queries - 【perf】 compute shelf_len once to avoid duplicate queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.