Show Calibre pages count in book detail view#3600
Closed
jarynclouatre wants to merge 1 commit intojaneczku:masterfrom
Closed
Show Calibre pages count in book detail view#3600jarynclouatre wants to merge 1 commit intojaneczku:masterfrom
jarynclouatre wants to merge 1 commit intojaneczku:masterfrom
Conversation
Collaborator
|
Without having calibre in the background to generate the page count this feature is a bit useless. This will cause 2 Billoon questions, as people don't understand why it's not working for certain books, or sometimes never |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3568
Calibre added a native
pagescolumn stored in thebooks_pages_linktable. This PR surfaces that data in the book detail view.Changes:
BooksPagesORM model incps/db.pymapping tobooks_pages_linkpagesrelationship andpage_countproperty to theBooksmodelcps/templates/detail.htmlafter the published dateThe field only renders when a page count is actually present, so it's fully backwards compatible with older Calibre databases that don't have the table populated yet.