Skip to content

Remove conf-g++ dependency#34

Open
ncihnegn wants to merge 1 commit intojanestreet:masterfrom
ncihnegn:patch-1
Open

Remove conf-g++ dependency#34
ncihnegn wants to merge 1 commit intojanestreet:masterfrom
ncihnegn:patch-1

Conversation

@ncihnegn
Copy link

@ncihnegn ncihnegn commented Sep 6, 2025

No description provided.

@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Sep 8, 2025
@dwang20151005
Copy link
Contributor

Hey, thanks for sending this. The diff is in a file that is generated as part of our export process and the person who works on that is out for a couple of weeks. I'll get back to you when I can figure something out.

@dwang20151005
Copy link
Contributor

Why do you want to remove this dependency?

Here's what I got by asking around internally:

We probably want to be sure a C++ compiler is available, which in some corner cases is not guaranteed. The only wait to test the change I can think of is to set up (typically using Docker) a Linux install such as the C compiler (used to build the opam switch) does not also support C++.

Since our best guess is that it fixes something in a scenario that we don't routinely test, I don't want to remove it unless it's actively causing problems somewhere else.

@ncihnegn
Copy link
Author

In macOS it prevents installation because gcc is missing.

@ncihnegn
Copy link
Author

Why not use conf-c++?

@dwang20151005
Copy link
Contributor

@xclerc wdyt?

@xclerc
Copy link
Contributor

xclerc commented Sep 16, 2025

Looking at the opam repository, it may
well be the case that we used conf-g++
because conf-c++ did not exist at the
time...

I think it is fine to change to conf-c++;
it is perhaps even better.

However, @ncihnegn, could you give
more details about the macOS failure.
I could not reproduce locally, and the
macOS boxes I have access to have
both /usr/bin/gcc and /usr/bin/g++.

@ncihnegn
Copy link
Author

=== install 1 package
  ∗ conf-g++         1.0                      [required by re2]

The following system packages will first need to be installed:
    gcc

<><> Handling external dependencies <><><><><><><><><><><><><><><><><><><><>  🐫

opam believes some required external dependencies are missing. opam can:
> 1. Run brew to install them (may need root/sudo access)
  2. Display the recommended brew command and wait while you run it manually (e.g. in another
     terminal)
  3. Continue anyway, and, upon success, permanently register that this external dependency is
     present, but not detectable
  4. Abort the installation

@xclerc
Copy link
Contributor

xclerc commented Sep 18, 2025

Thanks; I have never seen that on
macOS, and have brew in the
PATH.

I would suggest to change to
conf-c++.

@dwang20151005
Copy link
Contributor

Thanks, Xavier, I will change to conf-c++.

@dwang20151005
Copy link
Contributor

This change has been released internally. I've asked how long it'll take to make its way to github. I know the export is all automated now so I wouldn't expect that to take long.

@dwang20151005
Copy link
Contributor

Ah, sorry, there is a manual step I didn't know about. It'll be about a month before you see the change on github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants