config panel shows loaded config#13
Open
peterv959 wants to merge 1 commit intojangabrielsson:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I adjusted as little as I could to get the loaded emulator config values to display on the config panel. I sorted the keys. When the values are themselves javascript objects (i.e. a dictionary or a list) they are displayed on separate lines within the table row. I did not sort those keys. The argv parameter displays with the list indices as the "key." The colors parameter just has the key and value on each line. I contemplated making them tables within the table but opted not. Nor did I go to the trouble to recurse. I can't imagine the need for further nested objects. It wouldn't be hard to do but seemed like overkill. I hope you'll find it doesn't look much different than what you might have written. I used it as a learning exercise for Vue.