Revert back standard code for frmDefault#48
Merged
jangko merged 1 commit intojangko:masterfrom Aug 15, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #45 implemented the option for embedding, drawing, and the existing method of working with fonts. However, the new code has combined the drawing and the old method, which causes problems with the old way,
frmDefault.This PR re-implements the old method so the generated PDFs follow the original style again. I have verified this by combining the raw output using
cat x.pdf, and with this PR the only change in the PDFs from the repository is the creation date.Note for future updates: If there are any changes to formatting, all the demo PDFs should be re-created, or they should be generated and text-compared to ensure only creationDate is updated.